spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 10 Nov 2021 07:39:35 +0000 (10:39 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 12 Nov 2021 18:18:01 +0000 (18:18 +0000)
commit6532582c353f4c83e3ccdd7255020ab852b90b0b
treede1c395e91f0c6d03ccf06eb7de5da18fde946e7
parent12f62a857c83b2efcbf8d9961aacd352bf81ad3d
spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan()

This code has several issues:
1) It passes IS_ERR() to dev_err_probe() instead of PTR_ERR().
2) It always prints an error message, even when it succeeds.
3) The "if (ret < 0) {" conditions are never true.
4) If requesting "mas->tx" fails then it sets "mas->rx" to NULL but the
   intention was to set "mas->tx" to NULL.

Fixes: b59c122484ec ("spi: spi-geni-qcom: Add support for GPI dma")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20211110073935.GA5176@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-geni-qcom.c