net: stmmac: ensure LPI is disabled when disabling EEE
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 5 Feb 2025 13:39:50 +0000 (13:39 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Feb 2025 19:56:08 +0000 (11:56 -0800)
commit64c9936330ccba159f72faaaaa18bdc0f67f5a54
treeb6ed5d3c707c4ee5e23df372d9f780f08300843d
parenta923378ab0c438e43d7d35d1cf0be47d353f87b4
net: stmmac: ensure LPI is disabled when disabling EEE

When EEE is disabled, we call stmmac_set_eee_lpi_timer(..., 0).

For dwmac4, this will result in LPIATE being cleared, but LPIEN and
LPITXA being set, causing LPI mode to be signalled (if it wasn't
before).

For others MACs, stmmac_set_eee_lpi_timer() does nothing, which means
that LPI mode will continue to be signalled despite the expectation
for it to be disabled.

In both cases, LPI mode will be terminated when the transmitter has
a packet to send, and LPIEN will be cleared by hardware.

Call stmmac_reset_eee_mode() to ensure that LPI mode is disabled when
EEE mode is requested to be disabled.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tffd8-003ZHb-AX@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c