kconfig: Warn if there is more than one help text
authorUlf Magnusson <ulfalizer@gmail.com>
Fri, 12 Jan 2018 06:47:47 +0000 (07:47 +0100)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Sun, 21 Jan 2018 15:49:29 +0000 (00:49 +0900)
commit6479f327dea60ddc2be065c7d174273fb4837f03
tree9b8639c5b9ef8676cb8d1640b19a82bc4c0a62ff
parentb92d804a51796b77c7b2b11881b2700eaac88114
kconfig: Warn if there is more than one help text

Avoids mistakes like in the following real-world example, where only the
final help string ("Say Y...") was used. This particular example was
fixed in commit 561b29e4ec8d ("media: fix media Kconfig help syntax
issues").

  config DVB_NETUP_UNIDVB
   ...
select DVB_CXD2841ER if MEDIA_SUBDRV_AUTOSELECT
   ---help---
     Support for NetUP PCI express Universal DVB card.
       help
   Say Y when you want to support NetUP Dual Universal DVB card
        ...

This now prints the following warning:

  drivers/media/pci/netup_unidvb:13: warning: 'DVB_NETUP_UNIDVB' defined with more than one help text -- only the last one will be used

Also free() any extra help strings.

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kconfig/zconf.y