Revert "flow_offload: action should not be NULL when it is referenced"
authorIdo Schimmel <idosch@nvidia.com>
Thu, 19 Aug 2021 10:58:42 +0000 (13:58 +0300)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:35:52 +0000 (08:35 -0400)
commit645fd92c3ed4e3722a4d38fb1b4b2049529b7ebf
tree1ad7d87f1ceb30f28868af316cd06b672a13aef2
parent2f6c42806e10dc135cc5fe1ea1712b10f90aa1de
Revert "flow_offload: action should not be NULL when it is referenced"

[ Upstream commit fa05bdb89b01b098aad19ec0ebc4d1cc7b11177e ]

This reverts commit 9ea3e52c5bc8bb4a084938dc1e3160643438927a.

Cited commit added a check to make sure 'action' is not NULL, but
'action' is already dereferenced before the check, when calling
flow_offload_has_one_action().

Therefore, the check does not make any sense and results in a smatch
warning:

include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn:
variable dereferenced before check 'action' (see line 319)

Fix by reverting this commit.

Cc: gushengxian <gushengxian@yulong.com>
Fixes: 9ea3e52c5bc8 ("flow_offload: action should not be NULL when it is referenced")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://lore.kernel.org/r/20210819105842.1315705-1-idosch@idosch.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/flow_offload.h