once: add DO_ONCE_SLOW() for sleepable contexts
authorEric Dumazet <edumazet@google.com>
Sat, 1 Oct 2022 20:51:02 +0000 (13:51 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Oct 2022 12:29:11 +0000 (13:29 +0100)
commit62c07983bef9d3e78e71189441e1a470f0d1e653
treef0ad523a6d93dcb8da22283a69298bbe16036083
parentf75886a045531fedf4c11cf06d977a91f4cb266c
once: add DO_ONCE_SLOW() for sleepable contexts

Christophe Leroy reported a ~80ms latency spike
happening at first TCP connect() time.

This is because __inet_hash_connect() uses get_random_once()
to populate a perturbation table which became quite big
after commit 4c2c8f03a5ab ("tcp: increase source port perturb table to 2^16")

get_random_once() uses DO_ONCE(), which block hard irqs for the duration
of the operation.

This patch adds DO_ONCE_SLOW() which uses a mutex instead of a spinlock
for operations where we prefer to stay in process context.

Then __inet_hash_connect() can use get_random_slow_once()
to populate its perturbation table.

Fixes: 4c2c8f03a5ab ("tcp: increase source port perturb table to 2^16")
Fixes: 190cc82489f4 ("tcp: change source port randomizarion at connect() time")
Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/netdev/CANn89iLAEYBaoYajy0Y9UmGFff5GPxDUoG-ErVB2jDdRNQ5Tug@mail.gmail.com/T/#t
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willy Tarreau <w@1wt.eu>
Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/once.h
lib/once.c
net/ipv4/inet_hashtables.c