PCI: endpoint: pci-epf-vntb: Fix the incorrect usage of __iomem attribute
authorManivannan Sadhasivam <mani@kernel.org>
Wed, 9 Jul 2025 12:50:22 +0000 (18:20 +0530)
committerManivannan Sadhasivam <mani@kernel.org>
Mon, 21 Jul 2025 05:58:56 +0000 (11:28 +0530)
commit61ae7f8694fb4b57a8c02a1a8d2b601806afc999
tree1320561b40f436dfb332e89dcb8c2a8b1f852c95
parente7cd58d2fdf8b3d2cb8c1d7a6d8eac2c67e5e18b
PCI: endpoint: pci-epf-vntb: Fix the incorrect usage of __iomem attribute

__iomem attribute is supposed to be used only with variables holding the
MMIO pointer. But here, 'mw_addr' variable is just holding a 'void *'
returned by pci_epf_alloc_space(). So annotating it with __iomem is clearly
wrong. Hence, drop the attribute.

This also fixes the below sparse warning:

  drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17: warning: incorrect type in assignment (different address spaces)
  drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17:    expected void [noderef] __iomem *mw_addr
  drivers/pci/endpoint/functions/pci-epf-vntb.c:524:17:    got void *
  drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21: warning: incorrect type in assignment (different address spaces)
  drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21:    expected unsigned int [usertype] *epf_db
  drivers/pci/endpoint/functions/pci-epf-vntb.c:530:21:    got void [noderef] __iomem *mw_addr
  drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38: warning: incorrect type in argument 2 (different address spaces)
  drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38:    expected void *addr
  drivers/pci/endpoint/functions/pci-epf-vntb.c:542:38:    got void [noderef] __iomem *mw_addr

Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20250709125022.22524-1-mani@kernel.org
drivers/pci/endpoint/functions/pci-epf-vntb.c