mac80211: fix potential overflow when multiplying to u32 integers
authorColin Ian King <colin.king@canonical.com>
Fri, 5 Feb 2021 17:53:52 +0000 (17:53 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 12 Feb 2021 07:54:42 +0000 (08:54 +0100)
commit6194f7e6473be78acdc5d03edd116944bdbb2c4e
treeb2b0fca5c713d41010dc26a4c7590160c4c1fd11
parent10cb8e617560fc050a759a897a2dde07a5fe04cb
mac80211: fix potential overflow when multiplying to u32 integers

The multiplication of the u32 variables tx_time and estimated_retx is
performed using a 32 bit multiplication and the result is stored in
a u64 result. This has a potential u32 overflow issue, so avoid this
by casting tx_time to a u64 to force a 64 bit multiply.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 050ac52cbe1f ("mac80211: code for on-demand Hybrid Wireless Mesh Protocol")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210205175352.208841-1-colin.king@canonical.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mesh_hwmp.c