drm/i915/ddi: only call shutdown hooks for valid encoders
authorJani Nikula <jani.nikula@intel.com>
Mon, 30 Dec 2024 14:14:45 +0000 (16:14 +0200)
committerJani Nikula <jani.nikula@intel.com>
Fri, 3 Jan 2025 10:28:48 +0000 (12:28 +0200)
commit60a43ecbd59decb77b31c09a73f09e1d4f4d1c4c
tree7476dbf53288b9f91c646d268260dc9d19ebf7af
parentefa43b751637c0e16a92e1787f1d8baaf56dafba
drm/i915/ddi: only call shutdown hooks for valid encoders

DDI might be HDMI or DP only, leaving the other encoder
uninitialized. Calling the shutdown hook on an uninitialized encoder may
lead to a NULL pointer dereference. Check the encoder types (and thus
validity via the DP output_reg or HDMI hdmi_reg checks) before calling
the hooks.

Reported-and-tested-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Closes: https://lore.kernel.org/r/20241031105145.2140590-1-senozhatsky@chromium.org
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/8b197c50e7f3be2bbc07e3935b21e919815015d5.1735568047.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_ddi.c