rcutorture: Fix rcu_torture_fwd_cb_cr() data race
authorPaul E. McKenney <paulmck@kernel.org>
Fri, 5 Apr 2024 19:02:11 +0000 (12:02 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Thu, 6 Jun 2024 18:44:17 +0000 (11:44 -0700)
commit6040072f4774a575fa67b912efe7722874be337b
tree739a186b2493dc2187aa6cccbec988476bcd046a
parent43b39cafbaf66cbbdace321c01701154a1c05fdc
rcutorture: Fix rcu_torture_fwd_cb_cr() data race

On powerpc systems, spinlock acquisition does not order prior stores
against later loads.  This means that this statement:

rfcp->rfc_next = NULL;

Can be reordered to follow this statement:

WRITE_ONCE(*rfcpp, rfcp);

Which is then a data race with rcu_torture_fwd_prog_cr(), specifically,
this statement:

rfcpn = READ_ONCE(rfcp->rfc_next)

KCSAN located this data race, which represents a real failure on powerpc.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Marco Elver <elver@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Cc: <kasan-dev@googlegroups.com>
kernel/rcu/rcutorture.c