net: dsa: sja1105: fix kasan out-of-bounds warning in sja1105_table_delete_entry()
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 18 Mar 2025 11:57:16 +0000 (13:57 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 24 Mar 2025 22:20:23 +0000 (15:20 -0700)
commit5f2b28b79d2d1946ee36ad8b3dc0066f73c90481
treeb8beaaacc4dc9daf2985243254e7205b30910cd6
parentb6a177b559717b707087114e08537fd47a4d1aca
net: dsa: sja1105: fix kasan out-of-bounds warning in sja1105_table_delete_entry()

There are actually 2 problems:
- deleting the last element doesn't require the memmove of elements
  [i + 1, end) over it. Actually, element i+1 is out of bounds.
- The memmove itself should move size - i - 1 elements, because the last
  element is out of bounds.

The out-of-bounds element still remains out of bounds after being
accessed, so the problem is only that we touch it, not that it becomes
in active use. But I suppose it can lead to issues if the out-of-bounds
element is part of an unmapped page.

Fixes: 6666cebc5e30 ("net: dsa: sja1105: Add support for VLAN operations")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250318115716.2124395-4-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/sja1105/sja1105_static_config.c