vmcore: convert copy_oldmem_page() to take an iov_iter
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 29 Apr 2022 21:37:59 +0000 (14:37 -0700)
committerakpm <akpm@linux-foundation.org>
Fri, 29 Apr 2022 21:37:59 +0000 (14:37 -0700)
commit5d8de293c224896a4da99763fce4f9794308caf4
tree06554517aca8f686fdc890da04dd811c1254c995
parent04d168c6d42d1772d35372301a14bb20784c81c5
vmcore: convert copy_oldmem_page() to take an iov_iter

Patch series "Convert vmcore to use an iov_iter", v5.

For some reason several people have been sending bad patches to fix
compiler warnings in vmcore recently.  Here's how it should be done.
Compile-tested only on x86.  As noted in the first patch, s390 should take
this conversion a bit further, but I'm not inclined to do that work
myself.

This patch (of 3):

Instead of passing in a 'buf' and 'userbuf' argument, pass in an iov_iter.
s390 needs more work to pass the iov_iter down further, or refactor, but
I'd be more comfortable if someone who can test on s390 did that work.

It's more convenient to convert the whole of read_from_oldmem() to take an
iov_iter at the same time, so rename it to read_from_oldmem_iter() and add
a temporary read_from_oldmem() wrapper that creates an iov_iter.

Link: https://lkml.kernel.org/r/20220408090636.560886-1-bhe@redhat.com
Link: https://lkml.kernel.org/r/20220408090636.560886-2-bhe@redhat.com
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
12 files changed:
arch/arm/kernel/crash_dump.c
arch/arm64/kernel/crash_dump.c
arch/ia64/kernel/crash_dump.c
arch/mips/kernel/crash_dump.c
arch/powerpc/kernel/crash_dump.c
arch/riscv/kernel/crash_dump.c
arch/s390/kernel/crash_dump.c
arch/sh/kernel/crash_dump.c
arch/x86/kernel/crash_dump_32.c
arch/x86/kernel/crash_dump_64.c
fs/proc/vmcore.c
include/linux/crash_dump.h