macintosh: fix possible memory leak in macio_add_one_device()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 4 Nov 2022 03:25:51 +0000 (11:25 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Nov 2022 12:12:18 +0000 (23:12 +1100)
commit5ca86eae55a2f006e6c1edd2029b2cacb6979515
treeb3afea531615191ed4651b7f8f037d8ddc9a4a4e
parent3aa16303dc98b7b8baa2adbc3210fd513ec0e810
macintosh: fix possible memory leak in macio_add_one_device()

Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's
bus_id string array"), the name of device is allocated dynamically. It
needs to be freed when of_device_register() fails. Call put_device() to
give up the reference that's taken in device_initialize(), so that it
can be freed in kobject_cleanup() when the refcount hits 0.

macio device is freed in macio_release_dev(), so the kfree() can be
removed.

Fixes: 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221104032551.1075335-1-yangyingliang@huawei.com
drivers/macintosh/macio_asic.c