net: gemini: Fix another missing clk_disable_unprepare() in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 2 Sep 2020 11:56:31 +0000 (14:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Sep 2020 17:14:21 +0000 (19:14 +0200)
commit5c9f765dcd4ef92b285cd4312cf07a09cfc8cb02
treeb1e9c9ee429e969eb8573a5ca3d52be43aa23759
parentf555d57c8f1b9a6ebe959e690632ff7db173c576
net: gemini: Fix another missing clk_disable_unprepare() in probe

[ Upstream commit eb0f3bc463d59d86402f19c59aa44e82dc3fab6d ]

We recently added some calls to clk_disable_unprepare() but we missed
the last error path if register_netdev() fails.

I made a couple cleanups so we avoid mistakes like this in the future.
First I reversed the "if (!ret)" condition and pulled the code in one
indent level.  Also, the "port->netdev = NULL;" is not required because
"port" isn't used again outside this function so I deleted that line.

Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/cortina/gemini.c