Revert "vfio/type1: Unpin zero pages"
authorAlex Williamson <alex.williamson@redhat.com>
Thu, 29 Feb 2024 22:35:40 +0000 (15:35 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 4 Mar 2024 23:11:07 +0000 (16:11 -0700)
commit5b992412776cdf2ec88b5b5138112e6b36e47995
tree0f42d6ffbf689dbac9fcbe555627ab437264ff54
parent81617c17bf58f008a57da74b97e60a0bf8e971fd
Revert "vfio/type1: Unpin zero pages"

This reverts commit 873aefb376bbc0ed1dd2381ea1d6ec88106fdbd4.

This was a heinous workaround and it turns out it's been fixed in mm
twice since it was introduced.  Most recently, commit c8070b787519
("mm: Don't pin ZERO_PAGE in pin_user_pages()") would have prevented
running up the zeropage refcount, but even before that commit
84209e87c696 ("mm/gup: reliable R/O long-term pinning in COW mappings")
avoids the vfio use case from pinning the zeropage at all, instead
replacing it with exclusive anonymous pages.

Remove this now useless overhead.

Suggested-by: David Hildenbrand <david@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20240229223544.257207-1-alex.williamson@redhat.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/vfio_iommu_type1.c