scsi: scsi_transport_spi: Fix function pointer check
authorTom Rix <trix@redhat.com>
Sat, 27 Jun 2020 13:32:42 +0000 (06:32 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 30 Jun 2020 01:34:35 +0000 (21:34 -0400)
commit5aee52c44d9170591df65fafa1cd408acc1225ce
treea5806e52c145d28172236607f59e6d0490403af9
parent311950f8b8d80ba41aa09a26bcaf0c2231f8d264
scsi: scsi_transport_spi: Fix function pointer check

clang static analysis flags several null function pointer problems.

drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage]
spi_transport_max_attr(offset, "%d\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reviewing the store_spi_store_max macro

if (i->f->set_##field)
return -EINVAL;

should be

if (!i->f->set_##field)
return -EINVAL;

Link: https://lore.kernel.org/r/20200627133242.21618-1-trix@redhat.com
Reviewed-by: James Bottomley <jejb@linux.ibm.com>
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_transport_spi.c