clk: versatile: Add of_node_put() before return statement
authorSumera Priyadarsini <sylphrenadin@gmail.com>
Sat, 29 Aug 2020 17:57:04 +0000 (23:27 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Oct 2020 15:36:23 +0000 (17:36 +0200)
commit5a73735ee5b2d24372bcb9627083577c31763d3c
treef01b07b4ca0256371023af9fcf2a7454eaa60c36
parent39f785132eee9871cb67e340454073d20014b2c9
clk: versatile: Add of_node_put() before return statement

[ Upstream commit da9c43dc0e2ec5c42a3d414e389feb30467000e2 ]

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/versatile/clk-impd1.c