rcu: Use _full() API to debug synchronize_rcu()
authorUladzislau Rezki (Sony) <urezki@gmail.com>
Thu, 27 Feb 2025 13:16:13 +0000 (14:16 +0100)
committerBoqun Feng <boqun.feng@gmail.com>
Wed, 5 Mar 2025 02:44:29 +0000 (18:44 -0800)
commit5a562b8b3f5de4c50f4a9da92bfd3f0a6eebf081
treee821ff64f12cf61906210c2c79a0bef3114ac68e
parenta6cea3954e62bb200834830515b3e85c9db5c238
rcu: Use _full() API to debug synchronize_rcu()

Switch for using of get_state_synchronize_rcu_full() and
poll_state_synchronize_rcu_full() pair to debug a normal
synchronize_rcu() call.

Just using "not" full APIs to identify if a grace period is
passed or not might lead to a false-positive kernel splat.

It can happen, because get_state_synchronize_rcu() compresses
both normal and expedited states into one single unsigned long
value, so a poll_state_synchronize_rcu() can miss GP-completion
when synchronize_rcu()/synchronize_rcu_expedited() concurrently
run.

To address this, switch to poll_state_synchronize_rcu_full() and
get_state_synchronize_rcu_full() APIs, which use separate variables
for expedited and normal states.

Reported-by: cheung wall <zzqq0103.hey@gmail.com>
Closes: https://lore.kernel.org/lkml/Z5ikQeVmVdsWQrdD@pc636/T/
Fixes: 988f569ae041 ("rcu: Reduce synchronize_rcu() latency")
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20250227131613.52683-3-urezki@gmail.com
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
include/linux/rcupdate_wait.h
kernel/rcu/tree.c