flexfiles/pNFS: fix NULL checks on result of ff_layout_choose_ds_for_read
authorTigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Thu, 28 Aug 2025 14:51:00 +0000 (16:51 +0200)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 6 Sep 2025 20:51:25 +0000 (16:51 -0400)
commit5a46d2339a5ae268ede53a221f20433d8ea4f2f9
treeda1b91a5440f8cc7ac5db3c6e55c77264dc955fd
parentd3684397ea9ba2edf02be0aa2b4dcab3bd74c503
flexfiles/pNFS: fix NULL checks on result of ff_layout_choose_ds_for_read

Recent commit f06bedfa62d5 ("pNFS/flexfiles: don't attempt pnfs on fatal DS
errors") has changed the error return type of ff_layout_choose_ds_for_read() from
NULL to an error pointer. However, not all code paths have been updated
to match the change. Thus, some non-NULL checks will accept error pointers
as a valid return value.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: f06bedfa62d5 ("pNFS/flexfiles: don't attempt pnfs on fatal DS errors")
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/flexfilelayout/flexfilelayout.c