brcmfmac: Don't grow SKB by negative size
authorDaniel Stone <daniels@collabora.com>
Wed, 26 Jul 2017 11:24:10 +0000 (12:24 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 27 Jul 2017 11:02:16 +0000 (14:02 +0300)
commit58f36b4526add4870476e1dc97a8467cf16aeee6
treed95ab3fd79451caa17ec36932d99e6dbf5d5e648
parentd755cbc26e8295ae8e5d30425364e093b4247a85
brcmfmac: Don't grow SKB by negative size

The commit to rework the headroom check in start_xmit() now calls
pxskb_expand_head() unconditionally if the header is CoW. Unfortunately,
it does so with the delta between the extant headroom and the header
length, which may be negative if there is already sufficient headroom.

pskb_expand_head() does allow for size being 0, in which case it just
copies, so clamp the header delta to zero.

Opening Chrome (and all my tabs) on a PCIE device was enough to reliably
hit this.

Fixes: 270a6c1f65fe ("brcmfmac: rework headroom check in .start_xmit()")
Signed-off-by: Daniel Stone <daniels@collabora.com>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c