perf stat-display: Check if snprintf()'s fmt argument is NULL
authorKaige Ye <ye@kaige.org>
Fri, 4 Aug 2023 02:09:08 +0000 (10:09 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 21 Aug 2023 13:54:22 +0000 (10:54 -0300)
commit58a8d2edd57b35307d81ec6c304697707e6067c1
treebca704cb6ac07d38f03ee4ab6475b77489a02e23
parent7d9642311b6d9d319a6948581244561d2a0890a1
perf stat-display: Check if snprintf()'s fmt argument is NULL

It is undefined behavior to pass NULL as snprintf()'s fmt argument.
Here is an example to trigger the problem:

  $ perf stat --metric-only -x, -e instructions -- sleep 1
  insn per cycle,
  Segmentation fault (core dumped)

With this patch:

  $ perf stat --metric-only -x, -e instructions -- sleep 1
  insn per cycle,
  ,

Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Kaige Ye <ye@kaige.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/01CA7674B690CA24+20230804020907.144562-2-ye@kaige.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/stat-display.c