ALSA: usb-audio: Fix NULL pointer deref in snd_usb_power_domain_set()
authorKarol Kosik <k.kosik@outlook.com>
Thu, 10 Oct 2024 06:59:10 +0000 (23:59 -0700)
committerTakashi Iwai <tiwai@suse.de>
Thu, 10 Oct 2024 11:58:44 +0000 (13:58 +0200)
commit57c14b983f3b0293f68ef7395148dd80197f5f9d
tree6e2d7ff0d7878d13043e32802669550f62150b5d
parent9988844c457f6f17fb2e75aa000b6c3b1b673bb9
ALSA: usb-audio: Fix NULL pointer deref in snd_usb_power_domain_set()

Commit adding support for multiple control interfaces expanded struct
snd_usb_power_domain with pointer to control interface for proper control
message routing but missed one initialization point of this structure,
which has left new field with NULL value.

Standard mandates that each device has at least one control interface and
code responsible for power domain does not check for NULL values when
querying for control interface. This caused some USB devices to crash
the kernel.

Fixes: 6aa8700150f7 ("ALSA: usb-audio: Support multiple control interfaces")
Signed-off-by: Karol Kosik <k.kosik@outlook.com>
Link: https://patch.msgid.link/AS8P190MB1285B563C6B5394DB274813FEC782@AS8P190MB1285.EURP190.PROD.OUTLOOK.COM
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/stream.c