usb: gadget: fix potential double-free in m66592_probe.
authorQiushi Wu <wu000273@umn.edu>
Sat, 23 May 2020 04:06:25 +0000 (23:06 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:48:55 +0000 (17:48 +0200)
commit5712c7bfee30c7851af4355804c9f71c34994aca
tree00564a6d6024ba05442a84c8a095cddba4f0675e
parent2ede53dd99188eac0ebc900a1923bfb82afcac6c
usb: gadget: fix potential double-free in m66592_probe.

[ Upstream commit 44734a594196bf1d474212f38fe3a0d37a73278b ]

m66592_free_request() is called under label "err_add_udc"
and "clean_up", and m66592->ep0_req is not set to NULL after
first free, leading to a double-free. Fix this issue by
setting m66592->ep0_req to NULL after the first free.

Fixes: 0f91349b89f3 ("usb: gadget: convert all users to the new udc infrastructure")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/udc/m66592-udc.c