iommufd: Do not allow _iommufd_object_alloc_ucmd if abort op is set
authorNicolin Chen <nicolinc@nvidia.com>
Thu, 10 Jul 2025 20:23:54 +0000 (13:23 -0700)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 14 Jul 2025 16:46:27 +0000 (13:46 -0300)
commit5510bd89da24508f0e9ae04396e7eb6929ec0e18
tree29fd4f97c100de45f8a094f70de583ea5768503e
parent32b2d3a57e26804ca96d82a222667ac0fa226cb7
iommufd: Do not allow _iommufd_object_alloc_ucmd if abort op is set

An abort op was introduced to allow its caller to invoke it within a lock
in the caller's function. On the other hand, _iommufd_object_alloc_ucmd()
would invoke the abort op in iommufd_object_abort_and_destroy() that must
be outside the caller's lock. So, these two cannot work together.

Add a validation in the _iommufd_object_alloc_ucmd(). Pick -EOPNOTSUPP to
reject the function call, indicating that the object allocator is buggy.

Link: https://patch.msgid.link/r/20250710202354.1658511-1-nicolinc@nvidia.com
Suggested-by: Xu Yilun <yilun.xu@linux.intel.com>
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Xu Yilun <yilun.xu@linux.intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/main.c