netfilter: conntrack: helper: Replace -EEXIST by -EBUSY
authorPhil Sutter <phil@nwl.cc>
Mon, 18 Aug 2025 11:22:20 +0000 (13:22 +0200)
committerFlorian Westphal <fw@strlen.de>
Wed, 27 Aug 2025 09:53:38 +0000 (11:53 +0200)
commit54416fd76770bd04fc3c501810e8d673550bab26
treeaf4aecdff8e94c9621c0795fc409f2831ff66a72
parent479a54ab92087318514c82428a87af2d7af1a576
netfilter: conntrack: helper: Replace -EEXIST by -EBUSY

The helper registration return value is passed-through by module_init
callbacks which modprobe confuses with the harmless -EEXIST returned
when trying to load an already loaded module.

Make sure modprobe fails so users notice their helper has not been
registered and won't work.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Fixes: 12f7a505331e ("netfilter: add user-space connection tracking helper infrastructure")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nf_conntrack_helper.c