crypto: cavium - Fix the if condition to exit loop after timeout
authorEverest K.C <everestkc@everestkc.com.np>
Fri, 18 Oct 2024 16:23:10 +0000 (10:23 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 28 Oct 2024 10:33:11 +0000 (18:33 +0800)
commit53d91ca76b6c426c546542a44c78507b42008c9e
tree674e1d4a7ed0a117988a857b8f9cb812ff62662f
parent7a42b7b930aa9e0dfa42f5ef40af5bafad16b38d
crypto: cavium - Fix the if condition to exit loop after timeout

The while loop breaks in the first run because of incorrect
if condition. It also causes the statements after the if to
appear dead.
Fix this by changing the condition from if(timeout--) to
if(!timeout--).

This bug was reported by Coverity Scan.
Report:
CID 1600859: (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: udelay(30UL);

Fixes: 9e2c7d99941d ("crypto: cavium - Add Support for Octeon-tx CPT Engine")
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/cpt/cptpf_main.c