wifi: rtw89: mcc: prevent shift wrapping in rtw89_core_mlsr_switch()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 28 May 2025 08:11:02 +0000 (11:11 +0300)
committerPing-Ke Shih <pkshih@realtek.com>
Tue, 10 Jun 2025 01:30:46 +0000 (09:30 +0800)
commit53cf488927a0f79968f9c03c4d1e00d2a79731c3
tree08caa8613a8f04e54c26fb6c8e57092084bf9250
parent16e3d93c6183649a3b210f82b83c1cb12aa5e8a3
wifi: rtw89: mcc: prevent shift wrapping in rtw89_core_mlsr_switch()

The "link_id" value comes from the user via debugfs.  If it's larger
than BITS_PER_LONG then that would result in shift wrapping and
potentially an out of bounds access later.  In fact, we can limit it
to IEEE80211_MLD_MAX_NUM_LINKS (15).

Fortunately, only root can write to debugfs files so the security
impact is minimal.

Fixes: 9dd85e739ce0 ("wifi: rtw89: debug: add mlo_mode dbgfs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/aDbFFkX09K7FrL9h@stanley.mountain
drivers/net/wireless/realtek/rtw89/core.c