fs: reduce work in fdget_pos()
authorMateusz Guzik <mjguzik@gmail.com>
Wed, 19 Mar 2025 21:58:01 +0000 (22:58 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 20 Mar 2025 08:45:39 +0000 (09:45 +0100)
commit5370b43e4bcf60049bfd44db83ba8d2ec43d0152
tree0d5bfa2b45c0ec532de8f3f2fd3b66c09c850f2d
parentdba2e3b788f5ac70ebf717523433e1ceae3f0834
fs: reduce work in fdget_pos()

1. predict the file was found
2. explicitly compare the ref to "one", ignoring the dead zone

The latter arguably improves the behavior to begin with. Suppose the
count turned bad -- the previously used ref routine is going to check
for it and return 0, indicating the count does not necessitate taking
->f_pos_lock. But there very well may be several users.

i.e. not paying for special-casing the dead zone improves semantics.

While here spell out each condition in a dedicated if statement. This
has no effect on generated code.

Sizes are as follows (in bytes; gcc 13, x86-64):
stock: 321
likely():  298
likely()+ref: 280

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20250319215801.1870660-1-mjguzik@gmail.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/file.c
include/linux/file_ref.h