irqchip/i8259: Fix shutdown order by moving syscore_ops registration
authorAaro Koskinen <aaro.koskinen@iki.fi>
Wed, 6 Feb 2019 21:26:08 +0000 (23:26 +0200)
committerMarc Zyngier <marc.zyngier@arm.com>
Thu, 14 Feb 2019 10:42:11 +0000 (10:42 +0000)
commit518bfe84ec417318b2470652cdb27978ddfeaa59
treeeffefba61d0988980c5cb64f99ce5ed853d9f34d
parent3bdd7f7433fd1c71b7c5ff1223d29c419e3a9d54
irqchip/i8259: Fix shutdown order by moving syscore_ops registration

When using cpufreq on Loongson 2F MIPS platform, "poweroff"
command gets frequently stuck in syscore_shutdown(). The reason is
that i8259A_shutdown() gets called before cpufreq_suspend(), and if we
have pending work then irq_work_sync() in cpufreq_dbs_governor_stop()
gets stuck forever as we have all interrupts masked already.

irq-i8259 is registering syscore_ops using device_initcall(),
while cpufreq uses core_initcall(). Fix the shutdown order simply
by registering the irq syscore_ops during the early IRQ init instead
of using a separate initcall at later stage.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-i8259.c