selinux: hash context structure directly
authorOndrej Mosnacek <omosnace@redhat.com>
Fri, 17 Apr 2020 08:11:56 +0000 (10:11 +0200)
committerPaul Moore <paul@paul-moore.com>
Fri, 17 Apr 2020 20:04:34 +0000 (16:04 -0400)
commit50077289804c9bd4e6cfd5b3a10d4da0487f7e42
treed0eec42d8fa215c2a80419f934159286d5d025d5
parente67b2ec9f6171895e774f6543626913960e019df
selinux: hash context structure directly

Always hashing the string representation is inefficient. Just hash the
contents of the structure directly (using jhash). If the context is
invalid (str & len are set), then hash the string as before, otherwise
hash the structured data.

Since the context hashing function is now faster (about 10 times), this
patch decreases the overhead of security_transition_sid(), which is
called from many hooks.

The jhash function seemed as a good choice, since it is used as the
default hashing algorithm in rhashtable.

Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Reviewed-by: Jeff Vander Stoep <jeffv@google.com>
Tested-by: Jeff Vander Stoep <jeffv@google.com>
[PM: fixed some spelling errors in the comments pointed out by JVS]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/Makefile
security/selinux/ss/context.c [new file with mode: 0644]
security/selinux/ss/context.h
security/selinux/ss/ebitmap.c
security/selinux/ss/ebitmap.h
security/selinux/ss/mls.h
security/selinux/ss/policydb.c
security/selinux/ss/services.c
security/selinux/ss/services.h