wifi: rtw88: fix uninitialized use of primary channel index
authorPing-Ke Shih <pkshih@realtek.com>
Mon, 15 Aug 2022 06:20:04 +0000 (14:20 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 26 Aug 2022 10:16:19 +0000 (12:16 +0200)
commit4ffb4d25ef1251d57881da183d6bec7f2dfe1e32
tree1536b1e3c940b710830e48844e38d61336326368
parentbe50baa40e90a18c3750b31a49be64929488d84b
wifi: rtw88: fix uninitialized use of primary channel index

clang reports uninitialized use:

>> drivers/net/wireless/realtek/rtw88/main.c:731:2: warning: variable
   'primary_channel_idx' is used uninitialized whenever switch default is
   taken [-Wsometimes-uninitialized]
           default:
           ^~~~~~~
   drivers/net/wireless/realtek/rtw88/main.c:754:39: note: uninitialized
   use occurs here
           hal->current_primary_channel_index = primary_channel_idx;
                                                ^~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/realtek/rtw88/main.c:687:24: note: initialize the
   variable 'primary_channel_idx' to silence this warning
           u8 primary_channel_idx;
                                 ^
                                  = '\0'

This situation could not happen, because possible channel bandwidth
20/40/80MHz are enumerated.

Fixes: 341dd1f7de4c ("wifi: rtw88: add the update channel flow to support setting by parameters")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220815062004.22920-1-pkshih@realtek.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/realtek/rtw88/main.c