drm/i915/gvt: fix unterminated-string-initialization warning
authorJani Nikula <jani.nikula@intel.com>
Thu, 27 Mar 2025 12:47:39 +0000 (14:47 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 1 Apr 2025 07:52:02 +0000 (10:52 +0300)
commit4f8207469094bd04aad952258ceb9ff4c77b6bfa
tree779cf6a0145cf38c2c4f79cf3e3814236d6cc5c2
parent930af58421acf971a2f377c07d4cc74f5f520066
drm/i915/gvt: fix unterminated-string-initialization warning

Initializing const char opregion_signature[16] = OPREGION_SIGNATURE
(which is "IntelGraphicsMem") drops the NUL termination of the
string. This is intentional, but the compiler doesn't know this.

Switch to initializing header->signature directly from the string
litaral, with sizeof destination rather than source. We don't treat the
signature as a string other than for initialization; it's really just a
blob of binary data.

Add a static assert for good measure to cross-check the sizes.

Reported-by: Kees Cook <kees@kernel.org>
Closes: https://lore.kernel.org/r/20250310222355.work.417-kees@kernel.org
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13934
Tested-by: Nicolas Chauvet <kwizart@gmail.com>
Tested-by: Damian Tometzki <damian@riscv-rocks.de>
Cc: stable@vger.kernel.org
Reviewed-by: Zhenyu Wang <zhenyuw.linux@gmail.com>
Link: https://lore.kernel.org/r/20250327124739.2609656-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gvt/opregion.c