tcp: fix a signed-integer-overflow bug in tcp_add_backlog()
authorLu Wei <luwei32@huawei.com>
Fri, 21 Oct 2022 04:06:22 +0000 (12:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:57:52 +0000 (23:57 +0900)
commit4f23cb2be530785db284a685d1b1c30224d8a538
treee83776d1d2393af22350f5cb4fd638f40e3dba2d
parent49713d7c38588311815889cb8c766591255ec836
tcp: fix a signed-integer-overflow bug in tcp_add_backlog()

[ Upstream commit ec791d8149ff60c40ad2074af3b92a39c916a03f ]

The type of sk_rcvbuf and sk_sndbuf in struct sock is int, and
in tcp_add_backlog(), the variable limit is caculated by adding
sk_rcvbuf, sk_sndbuf and 64 * 1024, it may exceed the max value
of int and overflow. This patch reduces the limit budget by
halving the sndbuf to solve this issue since ACK packets are much
smaller than the payload.

Fixes: c9c3321257e1 ("tcp: add tcp_add_backlog()")
Signed-off-by: Lu Wei <luwei32@huawei.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ipv4/tcp_ipv4.c