selinux: clarify return code in filename_trans_read_helper_compat()
authorOndrej Mosnacek <omosnace@redhat.com>
Thu, 4 Apr 2024 15:16:19 +0000 (17:16 +0200)
committerPaul Moore <paul@paul-moore.com>
Thu, 4 Apr 2024 20:38:37 +0000 (16:38 -0400)
commit4e551db0426472ca305a2f3284b25af763bfe57d
treebc5340f3da2df7a18680544712d204f1418ba794
parentabb0f43fcdf2cde0beaf6bbe34723a3dca9f125b
selinux: clarify return code in filename_trans_read_helper_compat()

For the "conflicting/duplicate rules" branch in
filename_trans_read_helper_compat() the Smatch static checker reports:

    security/selinux/ss/policydb.c:1953 filename_trans_read_helper_compat()
    warn: missing error code 'rc'

While the value of rc will already always be zero here, it is not
obvious that it's the case and that it's the intended return value
(Smatch expects rc to be assigned within 5 lines from the goto).
Therefore, add an explicit assignment just before the goto to make the
intent more clear and the code less error-prone.

Fixes: c3a276111ea2 ("selinux: optimize storage of filename transitions")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/selinux/722b90c4-1f4b-42ff-a6c2-108ea262bd10@moroto.mountain/
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ss/policydb.c