phy: core: Fix that API devm_phy_destroy() fails to destroy the phy
authorZijun Hu <quic_zijuhu@quicinc.com>
Fri, 13 Dec 2024 12:36:43 +0000 (20:36 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 24 Dec 2024 14:25:37 +0000 (19:55 +0530)
commit4dc48c88fcf82b89fdebd83a906aaa64f40fb8a9
tree2fb735b582ed4fc49974e5d3f5756a80851fa3e9
parentc0b82ab95b4f1fbc3e3aeab9d829d012669524b6
phy: core: Fix that API devm_phy_destroy() fails to destroy the phy

For devm_phy_destroy(), its comment says it needs to invoke phy_destroy()
to destroy the phy, but it will not actually invoke the function since
devres_destroy() does not call devm_phy_consume(), and the missing
phy_destroy() call will cause that the phy fails to be destroyed.

Fortunately, the faulty API has not been used by current kernel tree.
Fix by using devres_release() instead of devres_destroy() within the API.

Fixes: ff764963479a ("drivers: phy: add generic PHY framework")
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-3-40ae28f5015a@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-core.c