mtd: nand: gpmi: Fix gpmi_nand_init() error path
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Mon, 10 Apr 2017 08:35:17 +0000 (10:35 +0200)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Thu, 1 Jun 2017 08:09:27 +0000 (10:09 +0200)
commit4d02423e9afe6c46142ce98bbcaf5167316dbfbf
tree8022670cace04e775873f5f45dca32b83444009b
parentd7e578c8118113789b7abd2977e208c64d6f8465
mtd: nand: gpmi: Fix gpmi_nand_init() error path

The GPMI driver is wrongly assuming that nand_release() can safely be
called on an uninitialized/unregistered NAND device.

Add a new err_nand_cleanup label in the error path and only execute if
nand_scan_tail() succeeded.

Note that we now call nand_cleanup() instead of nand_release()
(nand_release() is actually grouping the mtd_device_unregister() and
nand_cleanup() in one call) because there's no point in trying to
unregister a device that has never been registered.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Acked-by: Han Xu <han.xu@nxp.com>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
drivers/mtd/nand/gpmi-nand/gpmi-nand.c