mm: shmem: fix incorrect aligned index when checking conflicts
authorBaolin Wang <baolin.wang@linux.alibaba.com>
Wed, 31 Jul 2024 05:46:20 +0000 (13:46 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 8 Aug 2024 01:33:56 +0000 (18:33 -0700)
commit4cbf320b1500fe64fcef8c96ed74dfc1ae2c9e2c
tree5168b0054ebd2bc6af0cdebcdb9621ca8ebdab48
parentb66b1b71d7ff5464d23a0ac6f73fae461b7264fd
mm: shmem: fix incorrect aligned index when checking conflicts

In the shmem_suitable_orders() function, xa_find() is used to check for
conflicts in the pagecache to select suitable huge orders.  However, when
checking each huge order in every loop, the aligned index is calculated
from the previous iteration, which may cause suitable huge orders to be
missed.

We should use the original index each time in the loop to calculate a new
aligned index for checking conflicts to avoid this issue.

Link: https://lkml.kernel.org/r/07433b0f16a152bffb8cee34934a5c040e8e2ad6.1722404078.git.baolin.wang@linux.alibaba.com
Fixes: e7a2ab7b3bb5 ("mm: shmem: add mTHP support for anonymous shmem")
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Barry Song <21cnbao@gmail.com>
Cc: Gavin Shan <gshan@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Lance Yang <ioworker0@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Barry Song <baohua@kernel.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/shmem.c