signal: Properly deliver SIGSEGV from x86 uprobes
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 20 Jul 2018 01:48:30 +0000 (20:48 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Tue, 11 Sep 2018 19:18:53 +0000 (21:18 +0200)
commit4a63c1ffd384ebdce40aac9c997dab68379137be
treeca6699a58409ed188cc82860fd9144c155e6cc9f
parent55a3235fc71bf34303e34a95eeee235b2d2a35dd
signal: Properly deliver SIGSEGV from x86 uprobes

For userspace to tell the difference between an random signal
and an exception, the exception must include siginfo information.

Using SEND_SIG_FORCED for SIGSEGV is thus wrong, and it will result in
userspace seeing si_code == SI_USER (like a random signal) instead of
si_code == SI_KERNEL or a more specific si_code as all exceptions
deliver.

Therefore replace force_sig_info(SIGSEGV, SEND_SIG_FORCE, current)
with force_sig(SIG_SEGV, current) which gets this right and is shorter
and easier to type.

Fixes: 791eca10107f ("uretprobes/x86: Hijack return address")
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
arch/x86/kernel/uprobes.c