btrfs: qgroup: delete unnecessary check in btrfs_qgroup_check_inherit()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 7 Mar 2024 14:53:47 +0000 (17:53 +0300)
committerDavid Sterba <dsterba@suse.com>
Tue, 7 May 2024 19:31:02 +0000 (21:31 +0200)
commit4a43d735a6028a9852e72a3ce02343942fd73c22
tree09340ec0004ff46298a3bfe52401195377fd8516
parent01b69bf9906bf5bbea79c5427e318a836d5d14e3
btrfs: qgroup: delete unnecessary check in btrfs_qgroup_check_inherit()

This check "if (inherit->num_qgroups > PAGE_SIZE)" is confusing and
unnecessary.

The problem with the check is that static checkers flag it as a
potential mixup of between units of bytes vs number of elements.
Fortunately, the check can safely be deleted because the next check is
correct and applies an even stricter limit:

if (size != struct_size(inherit, qgroups, inherit->num_qgroups))
return -EINVAL;

The "inherit" struct ends in a variable array of __u64 and
"inherit->num_qgroups" is the number of elements in the array.  At the
start of the function we check that:

if (size < sizeof(*inherit) || size > PAGE_SIZE)
return -EINVAL;

Thus, since we verify that the whole struct fits within one page, that
means that the number of elements in the inherit->qgroups[] array must
be less than PAGE_SIZE.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c