wifi: ath12k: Correct tid cleanup when tid setup fails
authorSarika Sharma <quic_sarishar@quicinc.com>
Mon, 21 Jul 2025 06:17:49 +0000 (11:47 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Mon, 21 Jul 2025 21:34:01 +0000 (14:34 -0700)
commit4a2bf707270f897ab8077baee8ed5842a5321686
tree9d6646c2e6cb846f2c595da232dbe28ae68546df
parentc4825d540f4beb179d552f3aa1f44f8db5095fb6
wifi: ath12k: Correct tid cleanup when tid setup fails

Currently, if any error occurs during ath12k_dp_rx_peer_tid_setup(),
the tid value is already incremented, even though the corresponding
TID is not actually allocated. Proceed to
ath12k_dp_rx_peer_tid_delete() starting from unallocated tid,
which might leads to freeing unallocated TID and cause potential
crash or out-of-bounds access.

Hence, fix by correctly decrementing tid before cleanup to match only
the successfully allocated TIDs.

Also, remove tid-- from failure case of ath12k_dp_rx_peer_frag_setup(),
as decrementing the tid before cleanup in loop will take care of this.

Compile tested only.

Signed-off-by: Sarika Sharma <quic_sarishar@quicinc.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250721061749.886732-1-quic_sarishar@quicinc.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/dp.c