kgdbts: fix hw_access_break_test
authorFlorian Rommel <mail@florommel.de>
Mon, 12 Aug 2024 08:54:59 +0000 (10:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Aug 2024 09:27:38 +0000 (11:27 +0200)
commit4a017c0163833fa3b0ebd2419973d30e9bd67e1e
tree12c220a78058b821f19050e2d8c5b359b09b16ed
parent9ca12e50a48c100e3bda3e5152d2181f4a6649e2
kgdbts: fix hw_access_break_test

The test for access watchpoints (hw_access_break_test) was broken
(always failed) because the compiler optimized out the write to the
static helper variable (hw_break_val2), as it is never read anywhere.
This resulted in the target variable (hw_break_val) not being accessed
and thus the breakpoint not being triggered.

Remove the helper variable (hw_break_val2), and use READ_ONCE to force
reading the target variable (hw_break_val).

Signed-off-by: Florian Rommel <mail@florommel.de>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240812085459.291741-1-mail@florommel.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/kgdbts.c