sched/uclamp: Fix a deadlock when enabling uclamp static key
authorQais Yousef <qais.yousef@arm.com>
Thu, 16 Jul 2020 11:03:47 +0000 (12:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 11:07:37 +0000 (13:07 +0200)
commit49f70356153baa42eaf781466647d5ab2a79837c
tree901fe86949070cecf14459aefccb1ac6ad2ef460
parentaf3b204d2063ed58137efb69091fb03d196b70bb
sched/uclamp: Fix a deadlock when enabling uclamp static key

[ Upstream commit e65855a52b479f98674998cb23b21ef5a8144b04 ]

The following splat was caught when setting uclamp value of a task:

  BUG: sleeping function called from invalid context at ./include/linux/percpu-rwsem.h:49

   cpus_read_lock+0x68/0x130
   static_key_enable+0x1c/0x38
   __sched_setscheduler+0x900/0xad8

Fix by ensuring we enable the key outside of the critical section in
__sched_setscheduler()

Fixes: 46609ce22703 ("sched/uclamp: Protect uclamp fast path code with static key")
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200716110347.19553-4-qais.yousef@arm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sched/core.c