Bluetooth: fix init and cleanup of sco_conn.timeout_work
authorDesmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Fri, 3 Sep 2021 03:13:06 +0000 (23:13 -0400)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 3 Sep 2021 23:33:10 +0000 (16:33 -0700)
commit49d8a5606428ca0962d09050a5af81461ff90fbb
tree698d6a3a5bbd7dec1c3011657c0d63b8fb4d8052
parentf4712fa993f688d0a48e0c28728fcdeb88c1ea58
Bluetooth: fix init and cleanup of sco_conn.timeout_work

Before freeing struct sco_conn, all delayed timeout work should be
cancelled. Otherwise, sco_sock_timeout could potentially use the
sco_conn after it has been freed.

Additionally, sco_conn.timeout_work should be initialized when the
connection is allocated, not when the channel is added. This is
because an sco_conn can create channels with multiple sockets over its
lifetime, which happens if sockets are released but the connection
isn't deleted.

Fixes: ba316be1b6a0 ("Bluetooth: schedule SCO timeouts with delayed_work")
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/sco.c