smb: client: fix parsing of source mount option
authorPaulo Alcantara <pc@manguebit.com>
Wed, 28 Jun 2023 00:24:47 +0000 (21:24 -0300)
committerSteve French <stfrench@microsoft.com>
Wed, 28 Jun 2023 16:48:56 +0000 (11:48 -0500)
commit49024ec8795ed2bd7217c249ef50a70c4e25d662
tree4df4277d2a82273da28c5a200ceec7da205778b5
parentd439b29057e26464120fc6c18f97433aa003b5fe
smb: client: fix parsing of source mount option

Handle trailing and leading separators when parsing UNC and prefix
paths in smb3_parse_devname().  Then, store the sanitised paths in
smb3_fs_context::source.

This fixes the following cases

$ mount //srv/share// /mnt/1 -o ...
$ cat /mnt/1/d0/f0
cat: /mnt/1/d0/f0: Invalid argument

The -EINVAL was returned because the client sent SMB2_CREATE "\\d0\f0"
rather than SMB2_CREATE "\d0\f0".

$ mount //srv//share /mnt/1 -o ...
mount: Invalid argument

The -EINVAL was returned correctly although the client only realised
it after sending a couple of bad requests rather than bailing out
earlier when parsing mount options.

Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifs_dfs_ref.c
fs/smb/client/cifsproto.h
fs/smb/client/dfs.c
fs/smb/client/fs_context.c
fs/smb/client/misc.c