ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 4 Feb 2022 17:31:02 +0000 (18:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Feb 2022 11:54:24 +0000 (12:54 +0100)
commit48e413087de1bc688ad732839efc0a5627f38d34
tree43d2f2484cafbef8a9a2f46bf6d79953a8a1e035
parent3b72d3f0205ed88bc1e1029022e88b9754f67759
ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE

[ Upstream commit dc0075ba7f387fe4c48a8c674b11ab6f374a6acc ]

Commit 4a9af6cac050 ("ACPI: EC: Rework flushing of EC work while
suspended to idle") made acpi_ec_dispatch_gpe() check
pm_wakeup_pending(), but that is before canceling the SCI wakeup,
so pm_wakeup_pending() is always true.  This causes the loop in
acpi_ec_dispatch_gpe() to always terminate after one iteration which
may not be correct.

Address this issue by canceling the SCI wakeup earlier, from
acpi_ec_dispatch_gpe() itself.

Fixes: 4a9af6cac050 ("ACPI: EC: Rework flushing of EC work while suspended to idle")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/ec.c
drivers/acpi/sleep.c