net: sit: unregister_netdevice on newlink's error path
authorJakub Kicinski <kuba@kernel.org>
Thu, 14 Jan 2021 01:29:47 +0000 (17:29 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 14 Jan 2021 18:26:46 +0000 (10:26 -0800)
commit47e4bb147a96f1c9b4e7691e7e994e53838bfff8
tree9f6f1441fd7d9f964c6019f16fd80a292c8bd035
parent5b55299eed78538cc4746e50ee97103a1643249c
net: sit: unregister_netdevice on newlink's error path

We need to unregister the netdevice if config failed.
.ndo_uninit takes care of most of the heavy lifting.

This was uncovered by recent commit c269a24ce057 ("net: make
free_netdev() more lenient with unregistering devices").
Previously the partially-initialized device would be left
in the system.

Reported-and-tested-by: syzbot+2393580080a2da190f04@syzkaller.appspotmail.com
Fixes: e2f1f072db8d ("sit: allow to configure 6rd tunnels via netlink")
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://lore.kernel.org/r/20210114012947.2515313-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/sit.c