b43: N-PHY: Fix the update of coef for the PHY revision >= 3case
authorColin Ian King <colin.king@canonical.com>
Mon, 15 Feb 2021 12:05:32 +0000 (12:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Feb 2021 20:40:41 +0000 (12:40 -0800)
commit4773acf3d4b50768bf08e9e97a204819e9ea0895
tree298ab9e9b71d38afc88fa775d160d28990ecfc0e
parent2355a6773a2cb0d2dce13432dde78497f1d6617b
b43: N-PHY: Fix the update of coef for the PHY revision >= 3case

The documentation for the PHY update [1] states:

Loop 4 times with index i

    If PHY Revision >= 3
        Copy table[i] to coef[i]
    Otherwise
        Set coef[i] to 0

the copy of the table to coef is currently implemented the wrong way
around, table is being updated from uninitialized values in coeff.
Fix this by swapping the assignment around.

[1] https://bcm-v4.sipsolutions.net/802.11/PHY/N/RestoreCal/

Fixes: 2f258b74d13c ("b43: N-PHY: implement restoring general configuration")
Addresses-Coverity: ("Uninitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/broadcom/b43/phy_n.c