mlxsw: spectrum_trap: fix unintention integer overflow on left shift
authorColin Ian King <colin.king@canonical.com>
Thu, 2 Apr 2020 14:48:51 +0000 (15:48 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Apr 2020 01:00:01 +0000 (18:00 -0700)
commit468c2a100208461c1821315f6fd81b32b9d12561
treeb1a3f816ed2c0c4b798f31c00699b0322924b54f
parent2f5107c34df329854d9e0bcef8185db8c07b59e5
mlxsw: spectrum_trap: fix unintention integer overflow on left shift

Shifting the integer value 1 is evaluated using 32-bit
arithmetic and then used in an expression that expects a 64-bit
value, so there is potentially an integer overflow. Fix this
by using the BIT_ULL macro to perform the shift and avoid the
overflow.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 13f2e64b94ea ("mlxsw: spectrum_trap: Add devlink-trap policer support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.c