rpmsg: char: Avoid double destroy of default endpoint
authorShengjiu Wang <shengjiu.wang@nxp.com>
Wed, 21 Sep 2022 01:58:43 +0000 (09:58 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Wed, 21 Sep 2022 17:21:33 +0000 (11:21 -0600)
commit467233a4ac29b215d492843d067a9f091e6bf0c5
treec5a0ac92621e80179e76b41350a7071f2d6f5fe1
parent06564be4c03ff0e0b88c5a4a14a6527fcb070ffd
rpmsg: char: Avoid double destroy of default endpoint

The rpmsg_dev_remove() in rpmsg_core is the place for releasing
this default endpoint.

So need to avoid destroying the default endpoint in
rpmsg_chrdev_eptdev_destroy(), this should be the same as
rpmsg_eptdev_release(). Otherwise there will be double destroy
issue that ept->refcount report warning:

refcount_t: underflow; use-after-free.

Call trace:
 refcount_warn_saturate+0xf8/0x150
 virtio_rpmsg_destroy_ept+0xd4/0xec
 rpmsg_dev_remove+0x60/0x70

The issue can be reproduced by stopping remoteproc before
closing the /dev/rpmsgX.

Fixes: bea9b79c2d10 ("rpmsg: char: Add possibility to use default endpoint of the rpmsg device")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/1663725523-6514-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/rpmsg/rpmsg_char.c