igb: Remove redundant runtime resume for ethtool_ops
authorBjorn Helgaas <bhelgaas@google.com>
Mon, 25 Mar 2024 22:29:50 +0000 (17:29 -0500)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 8 Apr 2024 20:25:39 +0000 (13:25 -0700)
commit461359c4f3700b4bc4da0c3358be423296ee6561
tree6a744c75129f7ea5e4386363db9696a9799577e7
parentb2c289415b2b2ef112b78d5e73b4acecf5db409e
igb: Remove redundant runtime resume for ethtool_ops

749ab2cd1270 ("igb: add basic runtime PM support") added
ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to
resume suspended devices before any ethtool_ops callback and allow suspend
after it completed.

Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before
ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path,
so the device is resumed before any ethtool_ops callback even if the driver
didn't supply a .begin() callback.

Remove the .begin() and .complete() callbacks, which are now redundant
because dev_ethtool() already resumes the device.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igb/igb_ethtool.c