accel/ivpu: Reorder Doorbell Unregister and Command Queue Destruction
authorKarol Wachowski <karol.wachowski@intel.com>
Thu, 15 May 2025 09:41:24 +0000 (11:41 +0200)
committerJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Wed, 28 May 2025 09:49:29 +0000 (11:49 +0200)
commit4557cc834712eca4eae7adbd9f0a06bdd8f79c99
tree94d934928776fc6c6f074c98669ed10304d2c9d9
parent1c2c0e29f24360b3130c005a3c261cb8c7b363c6
accel/ivpu: Reorder Doorbell Unregister and Command Queue Destruction

Refactor ivpu_cmdq_unregister() to ensure the doorbell is unregistered
before destroying the command queue. The NPU firmware requires doorbells
to be unregistered prior to command queue destruction.

If doorbell remains registered when command queue destroy command is sent
firmware will automatically unregister the doorbell, making subsequent
unregister attempts no-operations (NOPs).

Ensure compliance with firmware expectations by moving the doorbell
unregister call ahead of the command queue destruction logic,
thus preventing unnecessary NOP operation.

Fixes: 465a3914b254 ("accel/ivpu: Add API for command queue create/destroy/submit")
Signed-off-by: Karol Wachowski <karol.wachowski@intel.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://lore.kernel.org/r/20250515094124.255141-1-jacek.lawrynowicz@linux.intel.com
drivers/accel/ivpu/ivpu_job.c